Skip to content
This repository was archived by the owner on May 28, 2018. It is now read-only.

JERSEY-2612 make it possible for custom javax.ws.rs.ext.ParamConverter t...#98

Merged
mpotociar merged 3 commits intojavaee:masterfrom
nicolasyanncouturier:JERSEY-2612
Oct 17, 2014
Merged

JERSEY-2612 make it possible for custom javax.ws.rs.ext.ParamConverter t...#98
mpotociar merged 3 commits intojavaee:masterfrom
nicolasyanncouturier:JERSEY-2612

Conversation

@nicolasyanncouturier
Copy link
Copy Markdown

...o handle when they are given null values (such as to support java.util.Optional for example)

@jerseyrobot
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@mpotociar
Copy link
Copy Markdown
Collaborator

Hi Nicolas, before review your pull request, we need you to sign Oracle Contributor Agreement.

See also more information about contributing to Jersey here:
https://jersey.java.net/scm.html#/Submitting_Patches_and_Contribute_Code

@mpotociar
Copy link
Copy Markdown
Collaborator

Jenkins, please test this patch.

@nicolasyanncouturier
Copy link
Copy Markdown
Author

Hi Marek,

The OCA is signed and sent.
I also rebased this branch on top of the sync'ed fork of master.
Finally, I had a look at the Jenkins build failure (which seems to have disappeared just now), but cannot see that the failure is related to my changes (this test passed locally both on cmdline Maven and within IntelliJ).

On a side note, as I proposed in the JIRA issue comment, I could get rid of the "Optional" thing and rephrase the issue and test so that it does not bring in that "non-spec compliant" example.

@mpotociar
Copy link
Copy Markdown
Collaborator

Jenkins, please retest this patch.

@nicolasyanncouturier
Copy link
Copy Markdown
Author

Seems like the copyrights were making jenkins build fail. Should be fixed now.

@AdamLindenthal
Copy link
Copy Markdown
Member

Jenkins, please retest this patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants